Re: [PATCH] drm/bridge: panel: Check device dependency before managing device link

[Linus Walleij]

On Mon, Nov 27, 2023 at 2:36 PM Ville Syrjälä
<ville.syrjala@xxxxxxxxxxxxxxx> wrote:

> > +     panel_bridge->is_independent = !device_is_dependent(drm_dev->dev,
> > +                                                         panel->dev);
>
> This broke the build. Looks like device_is_dependent() is not even exported.
> ERROR: modpost: "device_is_dependent" [drivers/gpu/drm/drm_kms_helper.ko] undefined!

Yep Ying made a fix, I just applied and pushed it because it was obviously
correct.

> The recommended defconfigs in rerere-cache do seem to have CONFIG_DRM_KMS_HELPER=m
> so this should have been caught before pushing. How did it slip through?

My neglect.

Neglect may have something to do with my desktop being 10 years+
old. Building random defconfigs on this machine takes so long time
that invariably other stuff has been pushed to the branch before
the compiles even complete.

Yeah I know. I should buy a better computer.

Yours,
Linus Walleij