RE: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string

[JeeHeng Sia]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Monday, November 27, 2023 4:49 PM
> To: JeeHeng Sia <jeeheng.sia@xxxxxxxxxxxxxxxx>; paul.walmsley@xxxxxxxxxx; palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx;
> conor@xxxxxxxxxx; kernel@xxxxxxxx; robh+dt@xxxxxxxxxx; emil.renner.berthing@xxxxxxxxxxxxx
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string
> 
> On 27/11/2023 02:36, Sia Jee Heng wrote:
> > Add starfive,jh8100-uart compatible string
> 
> Describe the hardware. Why is it in xilinx?
My bad. It should CDNS UART driver. Will fix it.
> 
> Also, missing full stop in each commit msg.
Noted.
> 
> >
> > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> > ---
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.
Noted. Should I resend the patches with the V1 tag and with addressed comments?
> 
> Best regards,
> Krzysztof