Re: [PATCH v9 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

[Donald Robson]

Hi Geert,

On Mon, 2023-11-27 at 09:39 +0100, Geert Uytterhoeven wrote:
> Hi Donald,
> 
> On Wed, Nov 22, 2023 at 5:36 PM Donald Robson <donald.robson@xxxxxxxxxx> wrote:
> > From: Sarah Walker <sarah.walker@xxxxxxxxxx>
> > 
> > Add the device tree binding documentation for the IMG AXE GPU used in
> > TI AM62 SoCs.
> > 
> > Co-developed-by: Frank Binns <frank.binns@xxxxxxxxxx>
> > Signed-off-by: Frank Binns <frank.binns@xxxxxxxxxx>
> > Signed-off-by: Sarah Walker <sarah.walker@xxxxxxxxxx>
> > Signed-off-by: Donald Robson <donald.robson@xxxxxxxxxx>
> 
> Thanks for your patch, which is now commit 6a85c3b14728f0d5
> ("dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU") in
> drm-misc/for-linux-next.
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr.yaml
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - ti,am62-gpu
> > +      - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable
> 
> Why the double "img", and not just "img,axe"?
> 

While the first 'img' is just short for 'Imagination', the second is the product
series name 'IMG-Axe' in lower case.  A quirk of the newer product names, really.
If we add older series they would be 'img,powervr-series[...]'.

Thanks for applying!
Donald

> Gr{oetje,eeting}s,
> 
>                         Geert
>