Re: [PATCH v14 6/8] dt-bindings: media: wave5: add yaml devicetree bindings

From: Geert Uytterhoeven
Date: Tue Nov 28 2023 - 05:32:16 EST


Hi Sebastian,

CC TI K3

On Wed, Nov 8, 2023 at 8:29 PM Sebastian Fricke
<sebastian.fricke@xxxxxxxxxxxxx> wrote:
> From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
>
> Add bindings for the wave5 chips&media codec driver
>
> Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>

Thanks for your patch, which is now commit de4b9f7e371a5384
("dt-bindings: media: wave5: add yaml devicetree bindings")
in media/master.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/cnm,wave521c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chips&Media Wave 5 Series multi-standard codec IP
> +
> +maintainers:
> + - Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
> + - Jackson Lee <jackson.lee@xxxxxxxxxxxxxxx>
> +
> +description:
> + The Chips&Media WAVE codec IP is a multi format video encoder/decoder
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,k3-j721s2-wave521c

This is the only compatible value defined which contains both "k3"
and "j72*". I assume the "k3-" part should be dropped?

> + - const: cnm,wave521c
> +

This also applies to the driver added in commit 9707a6254a8a6b97
("media: chips-media: wave5: Add the v4l2 layer") in media/master.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds