Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in bindings

From: Krishna Kurapati PSSNV
Date: Tue Nov 28 2023 - 06:32:28 EST




So back to my initial proposal, with a slight modification moving
pwr_event first (e.g. as it is not a wakeup interrupt):

qusb2-:

- const: pwr_event
- const: qusb2_phy
- const: ss_phy_irq (optional)

qusb2:

- const: pwr_event
- const: hs_phy_irq
- const: qusb2_phy
- const: ss_phy_irq (optional)

femto-:
- const: pwr_event
- const: dp_hs_phy_irq
- const: dm_hs_phy_irq
- const: ss_phy_irq (optional)

femto:
- const: pwr_event
- const: hs_phy_irq
- const: dp_hs_phy_irq
- const: dm_hs_phy_irq
- const: ss_phy_irq (optional)

That ss_phy_irq is optional would be expressed as minItems being one
less than maxItems for each permutation.

I am fine with this except that "femto-" might not be required. I looked at https://lore.kernel.org/all/20231122191436.3146-1-quic_kriskura@xxxxxxxxxxx/ and I see that all of them have hs_phy_irq.

Regards,
Krishna,