Re: [net-next PATCH v2 3/4] net: phy: restructure __phy_write/read_mmd to helper and phydev user

[Christian Marangi]

On Tue, Nov 28, 2023 at 01:46:10AM +0100, Andrew Lunn wrote:
> On Mon, Nov 27, 2023 at 12:51:40AM +0100, Christian Marangi wrote:
> > Restructure phy_write_mmd and phy_read_mmd to implement generic helper
> > for direct mdiobus access for mmd and use these helper for phydev user.
> > 
> > This is needed in preparation of PHY package API that requires generic
> > access to the mdiobus and are deatched from phydev struct but instead
> > access them based on PHY package base_addr and offsets.
> 
> Why is this all going into the header file?
>

Was following the pattern done by phy_package_read/write.

Considering those API are not single function call... I wonder if those
should be moved in phy_core.c instead of static inline them in the
header.

What do you think?

-- 
	Ansuel