Re: [PATCH v15] platform/x86: Add Silicom Platform Driver

From: Ilpo Järvinen
Date: Tue Nov 28 2023 - 07:55:00 EST


On Fri, 24 Nov 2023, Henry Shi wrote:

> platform/x86: Add Silicom Platform Driver
>
> Add Silicom platform (silicom-platform) Linux driver for Swisscom
> Business Box (Swisscom BB) as well as Cordoba family products.
>
> This platform driver provides support for various functions via
> the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON)
> and device attributes.
>
> Signed-off-by: Henry Shi <henryshi2018@xxxxxxxxx>

As far as I'm concerned, this seems to be okay shape now:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

It would be good for somebody to check if the devicename part of the led
.name is correct (as I cannot even myself figure out what exactly is
expected there).


--
i.