Re: [RFC PATCH 02/11] mm/mempolicy: swap cond reference counting logic in do_get_mempolicy

[Michal Hocko]

On Wed 22-11-23 16:11:51, Gregory Price wrote:
[...]
> @@ -982,11 +991,11 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask,
>  	}
>  
>   out:
> -	mpol_cond_put(pol);
> +	mpol_put(pol);
>  	if (vma)
>  		mmap_read_unlock(mm);
>  	if (pol_refcount)
> -		mpol_put(pol_refcount);
> +		mpol_cond_put(pol_refcount);

Maybe I am just misreading the patch but pol_refcount should be always
NULL with this patch

>  	return err;
>  }
>  
> -- 
> 2.39.1
> 

-- 
Michal Hocko
SUSE Labs