Re: [PATCH 5/5] ASoC: codecs: Add WCD939x Codec driver

[Neil Armstrong]

On 25/11/2023 13:07, Konrad Dybcio wrote:

<snip>

> > +
> > +static int wcd939x_io_init(struct snd_soc_component *component)
> > +{
> > +	snd_soc_component_write_field(component, WCD939X_ANA_BIAS,
> > +				      WCD939X_BIAS_ANALOG_BIAS_EN, 1);
> All of these values are BIT()s or 2-4 ORed BIT()s, can you check what they
> mean?
>
> Same for almost all other snd_soc_component_ write/modify functions

It uses snd_soc_component_write_field() with is the same as
regmap_write_bits(REGISTER, REGISTER_MASK,
                  FIELD_PREP(REGISTER_MASK, value);

So the 1 mean write in enable mask in this case, and mask is single bit,
read it exactly like if it was using FIELD_PREP(), but even for BITs.

I did check every single snd_soc_component_write_field() so far to check
it matches.

Or it's another question ?

Neil

> [...]

<snip>

> Konrad