Re: [PATCH] thermal: k3_j72xx_bandgap: implement suspend/resume support
From: kernel test robot
Date: Tue Nov 28 2023 - 15:59:02 EST
Hi Thomas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.7-rc3 next-20231128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Richard/thermal-k3_j72xx_bandgap-implement-suspend-resume-support/20231128-211217
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20231128130332.584127-1-thomas.richard%40bootlin.com
patch subject: [PATCH] thermal: k3_j72xx_bandgap: implement suspend/resume support
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231129/202311290245.aUcGn8BT-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231129/202311290245.aUcGn8BT-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311290245.aUcGn8BT-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/thermal/k3_j72xx_bandgap.c:554:12: warning: 'k3_j72xx_bandgap_resume' defined but not used [-Wunused-function]
554 | static int k3_j72xx_bandgap_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/k3_j72xx_bandgap.c:547:12: warning: 'k3_j72xx_bandgap_suspend' defined but not used [-Wunused-function]
547 | static int k3_j72xx_bandgap_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/k3_j72xx_bandgap_resume +554 drivers/thermal/k3_j72xx_bandgap.c
545
546 #ifdef CONFIG_PM
> 547 static int k3_j72xx_bandgap_suspend(struct device *dev)
548 {
549 pm_runtime_put_sync(dev);
550 pm_runtime_disable(dev);
551 return 0;
552 }
553
> 554 static int k3_j72xx_bandgap_resume(struct device *dev)
555 {
556 struct k3_j72xx_bandgap *bgp = dev_get_drvdata(dev);
557 int ret;
558
559 pm_runtime_enable(dev);
560 ret = pm_runtime_get_sync(dev);
561 if (ret < 0) {
562 pm_runtime_put_noidle(dev);
563 pm_runtime_disable(dev);
564 return ret;
565 }
566
567 k3_j72xx_bandgap_init_hw(bgp);
568
569 return 0;
570 }
571
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki