Re: [PATCH v1 1/1] units: Add missing header

[Andrew Morton]

On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> BITS_PER_BYTE is defined in bits.h.
> 
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")

This is post-6.6, so the fix should go into this -rc whatever happens, but...

It would be rather nice to know the effects of this change please.  Did
some build break?

> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_UNITS_H
>  #define _LINUX_UNITS_H
>  
> +#include <linux/bits.h>
>  #include <linux/math.h>
>  
>  /* Metric prefixes in accordance with Système international (d'unités) */
> -- 
> 2.43.0.rc1.1.gbec44491f096