Re: [PATCH] ksmbd: initialize ar to NULL

[Zongmin Zhou]

Friendly ping. I think this patch was forgotten.

Best regards!

On 2023/11/20 10:39, Zongmin Zhou wrote:
> Initialize ar to NULL to avoid the case of aux_size will be false,
> and kfree(ar) without ar been initialized will be unsafe.
> But kfree(NULL) is safe.
>
> Signed-off-by: Zongmin Zhou<zhouzongmin@xxxxxxxxxx>
> Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
> ---
>   fs/smb/server/ksmbd_work.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/server/ksmbd_work.c b/fs/smb/server/ksmbd_work.c
> index 44bce4c56daf..2510b9f3c8c1 100644
> --- a/fs/smb/server/ksmbd_work.c
> +++ b/fs/smb/server/ksmbd_work.c
> @@ -106,7 +106,7 @@ static inline void __ksmbd_iov_pin(struct ksmbd_work *work, void *ib,
>   static int __ksmbd_iov_pin_rsp(struct ksmbd_work *work, void *ib, int len,
>   			       void *aux_buf, unsigned int aux_size)
>   {
> -	struct aux_read *ar;
> +	struct aux_read *ar = NULL;
>   	int need_iov_cnt = 1;
>   
>   	if (aux_size) {