Re: [PATCH v2 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1

[Jacky Huang]

Dear Krzysztof,


On 2023/11/29 下午 04:11, Krzysztof Kozlowski wrote:
> On 29/11/2023 04:35, Jacky Huang wrote:
> > > > > Best regards,
> > > > > Krzysztof
> > > > Yes, it did pass the 'dtbs_check'. I guess the tool does not detect such
> > > > issues.
> > > > Anyway, I will fix it in the next version.
> > > Hm, I see your bindings indeed allow pin-.* and unit addresses, so it is
> > > the binding issue.
> > >
> > > The examples you used as reference - xlnx,zynqmp-pinctrl.yaml and
> > > realtek,rtd1315e-pinctrl.yaml - do not mix these as you do.
> > >
> > > I don't understand why do you need them yet. I don't see any populate of
> > > children. There are no compatibles, either.
> > >
> > > Which part of your driver uses them exactly?
> > >
> > > Best regards,
> > > Krzysztof
> > I will move the 'pcfg_default: pin-default' from dtsi to dts, like this:
> >
> > &pinctrl {
> >       pcfg_default: pin-default {
> >           slew-rate = <0>;
> >           input-schmitt-disable;
> >           bias-disable;
> >           power-source = <1>;
> >           drive-strength = <17100>;
> >       };
> This solves nothing. It's the same placement.
>
>
> Best regards,
> Krzysztof

OK, it stil be the binding issues.
For "^pin-[a-z0-9]+$", I reference to the "pcfg-[a-z0-9-]+$" of 
rockchip,pinctrl.yaml.

My intention is to describe a generic pin configuration, aiming to make 
the pin
description more concise. In actual testing, it proves to be effective.


Best Regards,
Jacky Huang