Re: [PATCH V2 1/5] dt-bindings: arm: cpus: Add qcom,oryon compatible

From: Sibi Sankar
Date: Wed Nov 29 2023 - 05:38:44 EST




On 11/20/23 12:14, Sibi Sankar wrote:
Hey Rob,

Thanks for taking time to review the series.

On 11/19/23 21:29, Rob Herring wrote:
On Fri, Nov 17, 2023 at 05:09:27PM +0530, Sibi Sankar wrote:
From: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>

These are the CPU cores in Qualcomm's X1E80100 SoC.

Signed-off-by: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
---

v2:
* Update the part number from sc8380xp to x1e80100.

  Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index ffd526363fda..cc5a21b47e26 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -198,6 +198,7 @@ properties:
        - qcom,kryo660
        - qcom,kryo685
        - qcom,kryo780
+      - qcom,oryon

Wasn't it previously said 'oryon' is not specific enough?

https://lore.kernel.org/lkml/b165d2cd-e8da-4f6d-9ecf-14df2b803614@xxxxxxxxxx/

The cpu part numbers were indeed different in engineering samples
which has now been fixed in the production version.

-Sibi


Also, please describe what oryon is in the commit msg.

ack. Will add more details in the next re-spin.

-Sibi


Rob