RE: [PATCH 2/2] mei: Add MEI hardware support for IVSC device

[Wu, Wentong]

> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> On Tue, Nov 28, 2023 at 08:34:06PM +0800, Wentong Wu wrote:
> > The protocol used for the IVSC device to communicate with HOST is MEI.
> > The MEI hardware interfaces for the IVSC device are implemented.
> >
> > The APIs are exposed by MEI framework to mei clients, e.g. mei_csi and
> > mei_ace.
> >
> > Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx>
> > Reviewed-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> > Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/misc/mei/Kconfig        |  13 ++
> >  drivers/misc/mei/Makefile       |   3 +
> >  drivers/misc/mei/platform-vsc.c | 442
> > ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 458 insertions(+)
> >  create mode 100644 drivers/misc/mei/platform-vsc.c
> >
> > diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
> > 470957a..2c5312b 100644
> > --- a/drivers/misc/mei/Kconfig
> > +++ b/drivers/misc/mei/Kconfig
> > @@ -71,6 +71,19 @@ config INTEL_MEI_VSC_HW
> >  	  This driver can also be built as a module. If so, the module
> >  	  will be called mei-vsc-hw.
> >
> > +config INTEL_MEI_VSC
> > +	tristate "Intel visual sensing controller device with ME interface"
> > +	select INTEL_MEI_VSC_HW
> 
> Changing the select here to depends on addresses the Kconfig option
> dependency issue 

Yes, this is the plan to address the warning. Thanks

> (as select just blindly selects the options while ignoring their
> dependencies).
> 
> I wouldn't mind having a single Kconfig option for the two drivers either.
> They're always used together, aren't they?

Thanks and yes, currently they're used together, but we may have more
flexibility if keep them separate to cover future hardware which may has
different transport layer.

BR,
Wentong
> 
> > +	depends on INTEL_MEI
> > +	help
> > +	  Intel MEI over SPI driver for Intel visual sensing controller
> > +	  (IVSC) device embedded in IA platform. It supports camera sharing
> > +	  between IVSC for context sensing and IPU for typical media usage.
> > +	  Select this config will enable transport layer for IVSC device.
> > +
> > +	  This driver can also be built as a module. If so, the module
> > +	  will be called mei-vsc.
> > +
> >  source "drivers/misc/mei/hdcp/Kconfig"
> >  source "drivers/misc/mei/pxp/Kconfig"
> >  source "drivers/misc/mei/gsc_proxy/Kconfig"
> 
> --
> Regards,
> 
> Sakari Ailus