Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting

From: Nam Cao
Date: Wed Nov 29 2023 - 09:15:19 EST


On Wed, Nov 29, 2023 at 02:55:18PM +0100, Linus Walleij wrote:
> On Wed, Nov 29, 2023 at 2:32 PM Nam Cao <namcao@xxxxxxxxxxxxx> wrote:
> > #define SPI_TRANS_FAIL_NO_START BIT(0)
> > +#define SPI_TRANS_FAIL_IO BIT(1)
>
> Is it obvious from context when these flags get set?
> from transfer_one() and in which flag field?
>
> Otherwise maybe we should add a comment.

Agree that the purpose of this flag is not clear. I will add some
description in v2.

Best regards,
Nam