Re: [PATCH 4.14 00/53] 4.14.331-rc2 review

[Sasha Levin]

On Wed, Nov 29, 2023 at 10:00:44AM +0100, Pavel Machek wrote:
> On Tue 2023-11-28 21:10:03, Greg Kroah-Hartman wrote:
> > On Tue, Nov 28, 2023 at 09:48:42PM +0100, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > > > > Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > > > > > > >     RDMA/hfi1: Use FIELD_GET() to extract Link Width
> > > > > > >
> > > > > > > This is a good cleanup, but not a bugfix.
> > > > > > >
> > > > > > > > Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > > > > > > >     atm: iphase: Do PCI error checks on own line
> > > > > > >
> > > > > > > Just a cleanup, not sure why it was picked for stable.
> > > > > >
> > > > > > Just an additional bit of information, there have been quite many cleanups
> > > > > > from me which have recently gotten the stable notification for some
> > > > > > mysterious reason. When I had tens of them in my inbox and for various
> > > > > > kernel versions, I immediately stopped caring to stop it from happening.
> > > > > >
> > > > > > AFAIK, I've not marked those for stable inclusion so I've no idea what
> > > > > > got them included.
> > > > >
> > > > > Fixes tag can do it. Plus, "AUTOSEL" robot does it randomly, with no
> > > > > human oversight :-(.
> > > >
> > > > the autosel bot has lots of oversight.
> > >
> > > Can you describe how that oversight works?
> >
> > There have been many papers and presentations about it, no need for me
> > to say it all here again...
>
> Give a pointer.
>
> And explain why AUTOSEL is full of cleanups, as noticed by Ilpo, me
> and others. AFAICT Sasha does not hand-check patches picked by
> AUTOSEL, simply spams the mailing lists, and hopes that maintainers
> will react. And they won't, because they don't understand the

Awesome feedback, thanks.

> implications, and simply ignore the spam. Or they will, and Sasha
> simply ignores the reply.

Incorrect, I just gotten tired of litigating this with *you*.

How about this: instead of complaining about work you get for free, try
doing it yourself and send us a list of patches that should go into the
-stable tree during the next merge window. Deal?

--
Thanks,
Sasha