Re: [PATCH v3 2/2] mm: memcg: introduce new event to trace shrink_memcg
From: Dmitry Rokosov
Date: Wed Nov 29 2023 - 12:50:11 EST
On Wed, Nov 29, 2023 at 09:33:41AM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2023 18:20:57 +0300 Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx> wrote:
>
> > Okay, I will try to prepare a new patch version with memcg printing from
> > lruvec and slab tracepoints.
> >
> > Then Andrew should drop the previous patchsets, I suppose. Please advise
> > on the correct workflow steps here.
>
> This series is present in mm.git's mm-unstable branch. Note
> "unstable". So dropping the v3 series and merging v4 is totally not a
> problem. It's why this branch exists - it's daily rebasing, in high
> flux.
>
> When a patchset is considered stabilized and ready, I'll move it into
> the mm-stable branch, which is (supposed to be) the non-rebasing tree
> for next merge window.
>
> If you have small fixes then I prefer little fixup patches against what
> is presently in mm-unstable.
>
> If you send replacement patches then no problem, I'll check to see
> whether I should turn them into little fixup deltas.
>
> I prefer little fixups so that people can see what has changed, so I
> can see which review/test issues were addressed and so that people
> don't feel a need to re-review the whole patchset.
>
> If generation of little fixups is impractical, I'll drop the old series
> entirely and I'll merge the new one.
>
> Each case is a judgement call, please send whatever you think makes
> most sense given the above.
Thank you for the detailed explanation! It is now completely clear to
me! I will be sending the new patch series soon.
--
Thank you,
Dmitry