Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property

[Krzysztof Kozlowski]

On 30/11/2023 12:15, Jinlong Mao wrote:
> 
> 
> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>> The inport of funnel@3023000 connects to a source which is not supported
>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>> to fix the warning. It will be added once the driver support to the
>>> source is added to linux kernel.
>>
>> Thanks for the changes, but that's not correct reason to remove DTS
>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>> for example is used in other projects - did you check if they have the
>> same issues? Anyway, DTS describes the hardware, so how current kernel
>> support defines what is and what is not in the hardware?
>>
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> The funnel dt node must have in-ports node. It is to describe the input
> connection of funnel HW. But there is no dt_binding doc to describe the
> DT node of the HW connected to funnel@3023000. So remove the funnel to 
> solve the warning as of now. The funnel will be added back once driver 
> and dt_binding are added for the HW.
> 
> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

Why we cannot add now the binding for the connected hardware? It's not
really related to the driver.

Best regards,
Krzysztof