[PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()

From: Andy Shevchenko
Date: Thu Nov 30 2023 - 09:32:21 EST


The pci_alloc_irq_vectors() returns a positive number on success.
Hence we have to filter the negative numbers for error condition.
Update the check accordingly.

Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
Reported-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/mfd/intel-lpss-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 8f5e10817a9c..4621d3950b8f 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
return ret;

ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
- if (ret)
+ if (ret < 0)
return ret;

info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);
--
2.43.0.rc1.1.gbec44491f096