Re: [PATCH v5 02/50] libperf: Lazily allocate/size mmap event copy

[Arnaldo Carvalho de Melo]

Em Thu, Nov 30, 2023 at 11:19:51AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Nov 30, 2023 at 10:15:43AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Nov 27, 2023 at 02:08:14PM -0800, Ian Rogers escreveu:
> > >  void perf_mmap__munmap(struct perf_mmap *map)
> > >  {
> > > -	if (map && map->base != NULL) {
> > > +	if (!map)
> > > +		return;
> > > +
> > > +	free(map->event_copy);
> > > +	map->event_copy = NULL;
> > 
> > I´m converting this to:
> > 
> > 	zfree(&map->event_copy);
> > 
> > Hopefully we'll find some tool to flag these before submitting patches,
> > does clang-tidy do these kinds of things?
> > 
> > Also, applied:
> > 
> >  b4 am -P2,4-7 -ctsl --cc-trailers 20231127220902.1315692-1-irogers@xxxxxxxxxx
> > 
> > The ones that Namhyung acked and that applied cleanly in order.
> > 
> > The first one, as Namhyung noted, is already merged.
> 
> I'll fix this later:
> 
> [perfbuilder@five ~]$ export BUILD_TARBALL=http://192.168.86.5/perf/perf-6.6.0-rc1.tar.xz
> [perfbuilder@five ~]$ time dm
>    1    16.97 almalinux:8                   : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-20) (GCC)
>     In file included from fs/fs.c:19:
>     fs/../io.h:94:46: error: unknown type name '__u64'
>      static inline int io__get_hex(struct io *io, __u64 *hex)

Added the following patch to just before your patches.

https://lore.kernel.org/all/ZWjDPL+IzPPsuC3X@xxxxxxxxxx/T/#u

tldr; missing linux/types.h for __u64 in api/io.h.

- Arnaldo