Re: [PATCH 1/1] libapi: Add missing linux/types.h header to get the __u64 type on io.h

From: Ian Rogers
Date: Thu Nov 30 2023 - 12:57:40 EST


On Thu, Nov 30, 2023 at 9:15 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> There are functions using __u64, so we need to have the linux/types.h
> header otherwise we'll break when its not included before api/io.h.
>
> Fixes: e95770af4c4a280f ("tools api: Add a lightweight buffered reading api")
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Link: https://lore.kernel.org/lkml/
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
> tools/lib/api/io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/api/io.h b/tools/lib/api/io.h
> index a77b74c5fb655a8c..2a7fe9758813172d 100644
> --- a/tools/lib/api/io.h
> +++ b/tools/lib/api/io.h
> @@ -12,6 +12,7 @@
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> +#include <linux/types.h>
>
> struct io {
> /* File descriptor being read/ */
> --
> 2.41.0
>