Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match_data()

[Geert Uytterhoeven]

Hi Miguel,

On Thu, Nov 30, 2023 at 7:55 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Wed, Nov 15, 2023 at 10:02 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > +       cfg = device_get_match_data(&pdev->dev);
>
> This sounds good to me, but a couple notes:
>
>   - This could be `dev` since we have it, no?

Indeed.

>   - Orthogonally, should we just directly initialize `cfg` since now we can?

Yes we can, it would still fit on an 80-column punched card ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds