Re: [PATCH 5.15 00/69] 5.15.141-rc1 review

[Harshit Mogalapalli]

Hi Greg,

Some notes below:

On 30/11/23 11:14 pm, Guenter Roeck wrote:
> On 11/30/23 09:21, Daniel Díaz wrote:
> > Hello!
> >
> >    make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/1/build ARCH=x86_64 SRCARCH=x86
> > CROSS_COMPILE=x86_64-linux-gnu- 'CC=sccache x86_64-linux-gnu-gcc'
> > 'HOSTCC=sccache gcc'
> >    arch/x86/kernel/smp.o: warning: objtool: sysvec_reboot()+0x51:
> > unreachable instruction
> >    x86_64-linux-gnu-ld: kernel/trace/trace_kprobe.o: in function
> > `__trace_kprobe_create':
> >    trace_kprobe.c:(.text+0x2f39): undefined reference to
> > `kallsyms_on_each_symbol'
> >    x86_64-linux-gnu-ld: kernel/trace/trace_kprobe.o: in function
> > `create_local_trace_kprobe':
> >    trace_kprobe.c:(.text+0x384b): undefined reference to
> > `kallsyms_on_each_symbol'
> >    make[1]: *** [/builds/linux/Makefile:1227: vmlinux] Error 1
> >    make[1]: Target '__all' not remade because of errors.
> >    make: *** [Makefile:226: __sub-make] Error 2
> >    make: Target '__all' not remade because of errors.
> > ----->8-----
> >
> > It only affects 5.15. Bisection in progress.
I have seen this too in our testing.
> I guess it will point to
>
> > > Francis Laniel <flaniel@xxxxxxxxxxxxxxxxxxx>
> > >      tracing/kprobes: Return EADDRNOTAVAIL when func matches several 
> > > symbols

Note:

1. This above commit also have a fix upstream,
926fe783c8a6 ("tracing/kprobes: Fix symbol counting logic by looking at 
modules as well")

2. I see the patch causing build failure is also queued in 5.10, 5.4 and 
4.19, 4.14 [1]

Thanks,
Harshit


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/tracing-kprobes-return-eaddrnotavail-when-func-matches-several-symbols.patch?id=1d4fa85848f798e9f2b141101cd0f9aa6af93395


> Guenter