Re: [PATCH 1/3] dt-bindings: soc: qcom: stats: Add QMP handle

From: Johan Hovold
Date: Fri Dec 01 2023 - 04:43:40 EST


On Thu, Nov 30, 2023 at 03:58:21PM +0100, Konrad Dybcio wrote:
> The stats can be expanded by poking the Always-On Subsystem through QMP.
> Allow passing a QMP handle for configurations that support it.

I know Qualcomm likes their opaque acronyms, but how about mentioning
what QMP stands for here and in the binding below?

Especially since we also have QMP PHYs (Qualcomm Multi PHY?), which I
doubt this is related to.

> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
> index 96a7f1822022..686a7ef2f48a 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml
> @@ -31,10 +31,24 @@ properties:
> reg:
> maxItems: 1
>
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM

Johan