Re: [RESEND PATCH] auxdisplay: img-ascii-lcd: Use device_get_match_data()

[Rob Herring]

On Thu, Nov 30, 2023 at 12:55 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Wed, Nov 15, 2023 at 10:02 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > +       cfg = device_get_match_data(&pdev->dev);
>
> This sounds good to me, but a couple notes:
>
>   - This could be `dev` since we have it, no?
>
>   - Orthogonally, should we just directly initialize `cfg` since now we can?
>
> Cc'ing Geert as well since he was the last one touching the file (in
> fact, he added the `dev` variable).

Can you fix that up while applying? This patch has only been ignored
for 2 months.

I really only care about getting the includes right so I can apply this[1].

Rob

[1] https://lore.kernel.org/all/20231129164316.2663565-1-robh@xxxxxxxxxx/