Re: [PATCH v1 2/3] hwmon: tmp513: Simplify with dev_err_probe()

[Guenter Roeck]

On 12/1/23 05:53, Andy Shevchenko wrote:
> On Thu, Nov 30, 2023 at 08:10:12PM -0800, Guenter Roeck wrote:
> > On Tue, Nov 28, 2023 at 08:06:03PM +0200, Andy Shevchenko wrote:
> > > Common pattern of handling deferred probe can be simplified with
> > > dev_err_probe().  Less code and also it prints the error value.
>
> ...
>
> > > +	if (IS_ERR(data->regmap))
> > > +		return dev_err_probe(dev, PTR_ERR(data->regmap), "failed to allocate register map\n");
> >
> > That line length was getting too long. Please consider running checkpatch
> > on your patches.
>
> I got your point, but checkpatch has no limit for the string literals, see
>
> f4c014c0dede ("checkpatch: allow printk strings to exceed 80 characters to maintain their searchability")
> ca56dc098caf ("checkpatch: check for quoted strings broken across lines")
>
> So, what the exact parameters should I supply to it?

None. Please just run checkpatch.

$ scripts/checkpatch.pl index.html
WARNING: line length of 102 exceeds 100 columns
#126: FILE: drivers/hwmon/tmp513.c:729:
+		return dev_err_probe(dev, PTR_ERR(data->regmap), "failed to allocate register map\n");

Guenter