Re: [PATCH v2 0/9] arm64: dts: mediatek: Add MT8186 Corsola Chromebooks

[Conor Dooley]

On Fri, Dec 01, 2023 at 03:07:04PM +0800, Chen-Yu Tsai wrote:
> Hi everyone,
> 
> This is v2 of the MT8186 Chromebook device tree series.
> 
> Changes since v1:
> - Reorder SKU numbers in descending order.
> - Fixed pinconfig node names
> - Moved pinctrl-* properties after interrupts-*
> - Switched to interrupts-extended for external components
> - Marked ADSP as explicitly disabled, with a comment explaining that it
>   stalls the system
> - Renamed "touchpad" to "trackpad"
> - Dropped bogus "no-laneswap" property from it6505 node
> - Moved "realtek,jd-src" property to after all the regulator supplies
> - Switched to macros for MT6366 regulator "regulator-allowed-modes"
> - Renamed "vgpu" regulator name to allow coupling, with a comment
>   containing the name used in the design
> - Renamed "cr50" node name to "tpm"
> - Moved trackpad_pins reference up to i2c2; workaround for second source
>   component resource sharing.
> - Fix copyright year
> - Fixed touchscreen supply name
> - Mark missing components as disabled instead of deleting the node
> - Dropped reset-gpios from touchscreen nodes
> - Drop status = "okay", which is the default
> 
> 
> This series adds device trees for the various MT8186 Chromebooks that
> were initially released. These are the Tentacruel / Tentacool devices
> released by ASUS, and the Steelix / Rusty / Magneton devices released
> by Lenovo. The device trees are taken from the downstream ChromeOS v5.15
> kernel, ported to mainline and cleaned up.
> 
> Corsola is the Google codename given to the MT8186 platform. This
> platform has two reference designs, Krabby and Kingler. Kingler was not
> used in any actual product, and is therefor not included. Steelix is
> an alternative design put forward and is effectively a mix-and-match of
> the two reference designs.
> 
> Most of the core design is shared between the variants. The differences
> are on which external components, such as the display bridges, are used.
> 
> Patch 1 cleans up the current list of MediaTek boards. The entries are
> reordered by SoC model first, then by board name.
> 
> Patch 2 through 5 add DT binding entries for the Tentacruel/Tentacool,
> Steelix, Rusty, and Magneton Chromebooks.
> 
> Patch 6 through 9 add board device tree files for these devices. Patch 6
> also adds the corsola dtsi file for the commonalities between the designs,
> as well as a dtsi file for the krabby reference design.
> 
> Currently external display support is missing. Audio is not working, as
> enabling the audio DSP causes my test systems to hang.

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature