Re: [PATCH] tty: max310x: work around regmap->regcache data corruption

From: Mark Brown
Date: Fri Dec 01 2023 - 13:34:46 EST


On Fri, Dec 01, 2023 at 01:27:36PM -0500, Hugo Villeneuve wrote:

> it is funny, as I am preparing to send a patch for the sc16is7xx driver
> to convert FIFO R/W to use the _noinc_ versions of regmap functions,
> inspired by your patch 3f42b142ea11 ("serial: max310x: fix IO data
> corruption in batched operations").

If you're working on that driver it'd also be good to update the current
use of cache bypass for the enhanced features/interrupt identification
register (and anything else in there, that did seem to be the only one)
to use regmap ranges instead - that'd remove the need for the efr_lock
and be a much more sensible/idiomatic use of the regmap APIs.

Attachment: signature.asc
Description: PGP signature