Re: [PATCH 2/2] x86/microcode: Rework early revisions reporting

From: Ashok Raj
Date: Sat Dec 02 2023 - 18:49:50 EST


On Sat, Dec 02, 2023 at 05:38:50PM +0100, Borislav Petkov wrote:
> On Fri, Dec 01, 2023 at 01:32:37PM -0800, Ashok Raj wrote:
> > dmesg for the microcode part here below:
> >
> > https://paste.debian.net/hidden/e911dffc/
>
> Thanks, it is all clear now.
>
> This should fix it:

Yes, this works as expected.

>
> ---
> From: "Borislav Petkov (AMD)" <bp@xxxxxxxxx>
> Date: Fri, 1 Dec 2023 14:35:06 +0100
> Subject: [PATCH] x86/microcode/intel: Set new revision only after a successful update
>
> This was meant to be done only when early microcode got updated
> successfully. Move it into the if-branch.
>
> Also, make sure the current revision is read unconditionally and only
> once.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>

Tested-by: Ashok Raj <ashok.raj@xxxxxxxxx>