Re: [PATCH v2 4/7] drm/msm/gem: Split out submit_unpin_objects() helper

From: Dmitry Baryshkov
Date: Sun Dec 03 2023 - 06:31:39 EST


On 21/11/2023 02:38, Rob Clark wrote:
From: Rob Clark <robdclark@xxxxxxxxxxxx>

Untangle unpinning from unlock/unref loop. The unpin only happens in
error paths so it is easier to decouple from the normal unlock path.

Since we never have an intermediate state where a subset of buffers
are pinned (ie. we never bail out of the pin or unpin loops) we can
replace the bo state flag bit with a global flag in the submit.

Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_gem.h | 6 +++---
drivers/gpu/drm/msm/msm_gem_submit.c | 22 +++++++++++++++++-----
drivers/gpu/drm/msm/msm_ringbuffer.c | 3 ++-
3 files changed, 22 insertions(+), 9 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry