RE: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase outstanding LMTST transactions

[Geethasowjanya Akula]

> -----Original Message-----
> From: Simon Horman <horms@xxxxxxxxxx>
> Sent: Friday, December 1, 2023 5:05 PM
> To: Geethasowjanya Akula <gakula@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx;
> davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; Sunil
> Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu Cherian
> <lcherian@xxxxxxxxxxx>; Jerin Jacob Kollanukkaran <jerinj@xxxxxxxxxxx>;
> Pavan Nikhilesh Bhagavatula <pbhagavatula@xxxxxxxxxxx>; Subbaraya
> Sundeep Bhatta <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam
> <hkelam@xxxxxxxxxxx>
> Subject: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
> outstanding LMTST transactions
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, Nov 29, 2023 at 04:51:55PM +0530, Geetha sowjanya wrote:
> > From: Pavan Nikhilesh <pbhagavatula@xxxxxxxxxxx>
> >
> > Currently the number of outstanding store transactions issued by AP as
> > a part of LMTST operation is set to 1 i.e default value.
> > This patch set to max supported value to increase the performance.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@xxxxxxxxxxx>
> > Signed-off-by: Geetha sowjanya <gakula@xxxxxxxxxxx>
> 
> ...
> 
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > index 0e74c5a2231e..93fedabfe31e 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > @@ -559,3 +559,12 @@ void rvu_nix_block_cn10k_init(struct rvu *rvu,
> struct nix_hw *nix_hw)
> >  	cfg |= BIT_ULL(1) | BIT_ULL(2);
> >  	rvu_write64(rvu, blkaddr, NIX_AF_CFG, cfg);  }
> > +
> > +void rvu_apr_block_cn10k_init(struct rvu *rvu) {
> > +	u64 reg;
> > +
> > +	reg = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_CFG);
> > +	reg |= 0xFULL << 35;
> 
> Hi Pavan and Geetha,
> 
> I think it would be best to avoid the magic value 35 here.
> 
> Best would probably be to use GENMASK_ULL and FIELD_PREP.
> Else defining something similar to APR_LMT_MAP_ENT_SCH_ENA_SHIFT.
> 
> It might also be nice to avoid the magic value 0xFULL using a #define.
Ack. Will submit next version.
> 
> > +	rvu_write64(rvu, BLKADDR_APR, APR_AF_LMT_CFG, reg); }
> > --
> > 2.25.1
> >