RE: [EXT] Re: [PATCH net-next v1] octeon_ep: control net API framework to support offloads

[Shinas Rasheed]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Saturday, December 2, 2023 9:29 AM
> To: Shinas Rasheed <srasheed@xxxxxxxxxxx>
> > +static netdev_features_t octep_fix_features(struct net_device *dev,
> > +					    netdev_features_t features)
> > +{
> > +	return (dev->hw_features & features);
> > +}
> 
> Why is this needed? The core kernel should already make sure
> unsupported features aren't requested.

Yes that is correct. I also don't see an interdependency between features to decide anything in this function currently, so I think perhaps fix features can be implemented later on or even just return the obtained features itself I guess. I'll submit an updated patch set. Any other nits to update in the next version?