Re: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops()
From: Christoph Hellwig
Date: Mon Dec 04 2023 - 03:45:36 EST
On Wed, Nov 29, 2023 at 05:43:04PM +0000, Robin Murphy wrote:
> The dma_base, size and iommu arguments are only used by ARM, and can
> now easily be deduced from the device itself, so there's no need to pass
> them through the callchain as well.
This looks even better than the patch form Jason that only removed the
iommu argument:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
I wonder if it makes sense to also remove the coherent argument
by setting up dev->dma_coherent in the caller. That would require
a pretty careful audit as we're doing a few weird things in that
area, though.