Re: [PATCH v2 2/2] sched/fair: Simplify util_est

[Vincent Guittot]

On Sun, 3 Dec 2023 at 00:38, Qais Yousef <qyousef@xxxxxxxxxxx> wrote:
>
> On 12/01/23 17:16, Vincent Guittot wrote:
>
> >  /*
> >   * The load/runnable/util_avg accumulates an infinite geometric series
> >   * (see __update_load_avg_cfs_rq() in kernel/sched/pelt.c).
> > @@ -505,9 +469,20 @@ struct sched_avg {
> >       unsigned long                   load_avg;
> >       unsigned long                   runnable_avg;
> >       unsigned long                   util_avg;
> > -     struct util_est                 util_est;
> > +     unsigned int                    util_est;
> >  } ____cacheline_aligned;
>
> unsigned long would be better?

I thought about changing it to unsigned long but I prefered to keep
using the same type as before for the ewma as we don't need to extend
it