Re: [PATCH v5 6/9] tty: serial: amba-pl011: fix formatting of conditions

[Linus Walleij]

On Thu, Nov 30, 2023 at 3:07 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:

> Fix the following checkpatch warnings & checks:
>
>         $ ./scripts/checkpatch.pl --strict --file \
>         drivers/tty/serial/amba-pl011.c
>
>     CHECK: Unbalanced braces around else statement
>     CHECK: Unnecessary parentheses around '[...]'
>     CHECK: braces {} should be used on all arms of this statement
>     CHECK: Comparison to NULL could be written "[...]"
>     WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij