Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset

[Halil Pasic]

On Wed, 29 Nov 2023 09:35:24 -0500
Tony Krowiak <akrowiak@xxxxxxxxxxxxx> wrote:

> In the current implementation, response code 01 (AP queue number not valid)
> is handled as a default case along with other response codes returned from
> a queue reset operation that are not handled specifically. Barring a bug,
> response code 01 will occur only when a queue has been externally removed
> from the host's AP configuration; nn this case, the queue must
> be reset by the machine in order to avoid leaking crypto data if/when the
> queue is returned to the host's configuration.

s/if\/when/at latest before/

I would argue that some of the cleanups need to happen before even 01 is
reflected...

The code comments may also require a similar rewording. With that fixed:
Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx>

Regards,
Halil

> The response code 01 case
> will be handled specifically by logging a WARN message followed by cleaning
> up the IRQ resources.
> 
> Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>