Re: [PATCH v1 1/1] checkpatch: Add dev_err_probe() to the list of Log Functions

[Andy Shevchenko]

On Fri, Dec 01, 2023 at 02:29:57PM -0800, Joe Perches wrote:
> On Fri, 2023-12-01 at 19:07 +0200, Andy Shevchenko wrote:
> > Currently the [style] behaviour is
> > inconsistent independently on somebody's preferences...
> 
> <shrug>  Which is IMO perfectly fine.
> 
> The ratio of multiple line and single line uses
> of dev_err_probe is ~50:50
> 
> $ git grep -w dev_err_probe | grep -P ';\s*$' | wc -l
> 1532
> $ git grep -w dev_err_probe | grep -P ',\s*$' | wc -l
> 1871

My point is that checkpatch won't warn on dev_err(..., "very long line\n");
while doing the same on dev_err_probe() even if the line is shorter than in
dev_err() case. This inconsistency I am talking about.

-- 
With Best Regards,
Andy Shevchenko