Re: [PATCH 1/2] drm/imagination: Removed unused functions in pvr_fw_trace

[Maxime Ripard]

Hi,

On Mon, Dec 04, 2023 at 01:36:11PM +0000, Donald Robson wrote:
> Fixing the warning below due to an unused file level vtable. Removing
> only this causes additional warnings for the now unused functions, so
> I've removed those too.
> 
> >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
>      205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@xxxxxxxxx/
> Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")

That commit doesn't exist (upstream).

You made that mistake on the 5 patches you sent last week too but I
forgot to tell you about it. Are you working from a private branch?

Maxime

Attachment: signature.asc
Description: PGP signature