Re: [PATCH v2 11/36] media: ti: davinci: Remove useless setting of min_buffers_needed

[Hans Verkuil]

On 04/12/2023 14:22, Benjamin Gaignard wrote:
> This driver uses min_buffers_needed which vb2 uses to ensure
> start_streaming is called when at least 'min_buffers_needed'
> buffers are queued. However, this driver doesn't need this,
> it can stream fine without any buffers queued.
> Just drop this unnecessary restriction.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> CC: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
> ---
>  drivers/media/platform/ti/davinci/vpif_capture.c | 1 -
>  drivers/media/platform/ti/davinci/vpif_display.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
> index fc42b4bc37e6..300c3cb5cbed 100644
> --- a/drivers/media/platform/ti/davinci/vpif_capture.c
> +++ b/drivers/media/platform/ti/davinci/vpif_capture.c
> @@ -1429,7 +1429,6 @@ static int vpif_probe_complete(void)
>  		q->mem_ops = &vb2_dma_contig_memops;
>  		q->buf_struct_size = sizeof(struct vpif_cap_buffer);
>  		q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
> -		q->min_buffers_needed = 1;
>  		q->lock = &common->lock;
>  		q->dev = vpif_dev;
>  
> diff --git a/drivers/media/platform/ti/davinci/vpif_display.c b/drivers/media/platform/ti/davinci/vpif_display.c
> index 9dbab1003c1d..d45391a4d8f2 100644
> --- a/drivers/media/platform/ti/davinci/vpif_display.c
> +++ b/drivers/media/platform/ti/davinci/vpif_display.c
> @@ -1169,7 +1169,6 @@ static int vpif_probe_complete(void)
>  		q->mem_ops = &vb2_dma_contig_memops;
>  		q->buf_struct_size = sizeof(struct vpif_disp_buffer);
>  		q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
> -		q->min_buffers_needed = 1;
>  		q->lock = &common->lock;
>  		q->dev = vpif_dev;
>  		err = vb2_queue_init(q);

Drop this patch, this is really needed.

Regards,

	Hans