Re: [PATCH v2 13/36] media: ti: j721e-csi2rx: Remove useless setting of min_buffers_needed

[Hans Verkuil]

On 04/12/2023 14:23, Benjamin Gaignard wrote:
> This driver uses min_buffers_needed which vb2 uses to ensure
> start_streaming is called when at least 'min_buffers_needed'
> buffers are queued. However, this driver doesn't need this,
> it can stream fine without any buffers queued.
> Just drop this unnecessary restriction.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> CC: Jai Luthra <j-luthra@xxxxxx>
> ---
>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index ada61391c8d2..1e5f68f50afb 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -873,7 +873,6 @@ static int ti_csi2rx_init_vb2q(struct ti_csi2rx_dev *csi)
>  	q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
>  	q->dev = dmaengine_get_dma_device(csi->dma.chan);
>  	q->lock = &csi->mutex;
> -	q->min_buffers_needed = 1;
>  
>  	ret = vb2_queue_init(q);
>  	if (ret)

Drop this patch, this is needed.

Regards,

	Hans