Re: [PATCH] x86/CPU/AMD: Add X86_FEATURE_ZEN1

[Tom Lendacky]

On 12/2/23 06:49, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@xxxxxxxxx>
> Date: Sat, 2 Dec 2023 12:50:23 +0100
>
> Add a synthetic feature flag specifically for first generation Zen
> machines. There's need to have a generic flag for all Zen generations so
> make X86_FEATURE_ZEN be that flag.
>
> Fixes: 30fa92832f40 ("x86/CPU/AMD: Add ZenX generations flags")
> Suggested-by: Brian Gerst <brgerst@xxxxxxxxx>
> Suggested-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> Link: https://lore.kernel.org/r/dc3835e3-0731-4230-bbb9-336bbe3d042b@xxxxxxx
> ---

>   
> -	if (boot_cpu_has(X86_FEATURE_ZEN))
> +	if (boot_cpu_has(X86_FEATURE_ZEN1))
>   		init_amd_zen(c);

Should this be renamed to init_amd_zen1(), just to avoid confusion?

Thanks,
Tom


>   	else if (boot_cpu_has(X86_FEATURE_ZEN2))
>   		init_amd_zen2(c);