Re: [PATCH V2 net 1/2] net: hns: fix wrong head when modify the tx feature when sending packets

[Jijie Shao]

on 2023/12/4 18:15, Wojciech Drewek wrote:
> On 04.12.2023 02:10, Jijie Shao wrote:
> > From: Yonglong Liu <liuyonglong@xxxxxxxxxx>
> >
> > When modify the tx feature, the hns driver will modify the
> Upon changing the...
>
> > maybe_stop_tx() and fill_desc() functions, if the modify happens
> > during packet sending, will cause the hardware and software
> > pointers do not match, and the port can not work anymore.
> >
> > This patch deletes the maybe_stop_tx() and fill_desc() functions
> > modification when setting tx feature, and use the skb_is_gro()
> > to determine use tso functions or non-tso functions when packets
> > sending.
> and use the skb_is_gro() to determine which functions to use in the tx path.
> > Fixes: 38f616da1c28 ("net:hns: Add support of ethtool TSO set option for Hip06 in HNS")
> > Signed-off-by: Yonglong Liu <liuyonglong@xxxxxxxxxx>
> > Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> > ---
> Some commit msg suggestions, other than that:
> Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>
Thanks，
  commit msg is refined in v3
  Jijie