Re: [PATCH 2/2] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend

From: Linus Walleij
Date: Mon Dec 04 2023 - 09:47:29 EST


On Sun, Dec 3, 2023 at 4:25 AM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:

> If a pin isn't marked as a wake source processing any interrupts is
> just going to destroy battery life. The APU may wake up from a hardware
> sleep state to process the interrupt but not return control to the OS.
>
> Mask interrupt for all non-wake source pins at suspend. They'll be
> re-enabled at resume.
>
> Reported-and-tested-by: Marcus Aram <marcus+oss@xxxxxxx>
> Reported-and-tested-by: Mark Herbert <mark.herbert42@xxxxxxxxx>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2812
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

I applied this patch (2/2) to the pin control tree for fixes.

Yours,
Linus Walleij