Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset

[Christian Borntraeger]

Am 04.12.23 um 15:53 schrieb Tony Krowiak:
> On 11/29/23 12:12, Christian Borntraeger wrote:
> > Am 29.11.23 um 15:35 schrieb Tony Krowiak:
> > > In the current implementation, response code 01 (AP queue number not valid)
> > > is handled as a default case along with other response codes returned from
> > > a queue reset operation that are not handled specifically. Barring a bug,
> > > response code 01 will occur only when a queue has been externally removed
> > > from the host's AP configuration; nn this case, the queue must
> > > be reset by the machine in order to avoid leaking crypto data if/when the
> > > queue is returned to the host's configuration. The response code 01 case
> > > will be handled specifically by logging a WARN message followed by cleaning
> > > up the IRQ resources.
> >
> > To me it looks like this can be triggered by the LPAR admin, correct? So it
> > is not desireable but possible.
> > In that case I prefer to not use WARN, maybe use dev_warn or dev_err instead.
> > WARN can be a disruptive event if panic_on_warn is set.
>
> Yes, it can be triggered by the LPAR admin. I can't use dev_warn here because we don't have a reference to any device, but I can use pr_warn if that suffices.

Ok, please use pr_warn then.