Re: [PATCH v3] usbip: Don't submit special requests twice

[Shuah Khan]

On 11/30/23 16:10, Simon Holesch wrote:
> Skip submitting URBs, when identical requests were already sent in
> tweak_special_requests(). Instead call the completion handler directly
> to return the result of the URB.
>
> Even though submitting those requests twice should be harmless, there
> are USB devices that react poorly to some duplicated requests.
>
> One example is the ChipIdea controller implementation in U-Boot: The
> second SET_CONFIURATION request makes U-Boot disable and re-enable all
> endpoints. Re-enabling an endpoint in the ChipIdea controller, however,
> was broken until U-Boot commit b272c8792502 ("usb: ci: Fix gadget
> reinit").
>
> Signed-off-by: Simon Holesch <simon@xxxxxxxxxx>
> ---
>
> Changes in v3:
> - handle errors in tweak_* routines: send URB if tweaking fails
>
> Changes in v2:
> - explain change in commit message
>
> Thanks again for the feedback!

Looks good to me.

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah