Re: [PATCH] md/md-multipath: Convert "struct mpconf" to flexible array

From: Kees Cook
Date: Mon Dec 04 2023 - 17:20:41 EST


On Sun, Dec 03, 2023 at 08:48:06PM +0100, Christophe JAILLET wrote:
> The 'multipaths' field of 'struct mpconf' can be declared as a flexible
> array.
>
> The advantages are:
> - 1 less indirection when accessing to the 'multipaths' array
> - save 1 pointer in the structure
> - improve memory usage
> - give the opportunity to use __counted_by() for additional safety
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

This looks like a really nice conversion. I haven't run-tested this, but
it reads correct to me.

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook