Re: [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset

From: Tengfei Fan
Date: Mon Dec 04 2023 - 19:59:32 EST




在 12/4/2023 5:57 PM, Linus Walleij 写道:
On Fri, Dec 1, 2023 at 10:33 PM Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
On Thu, Nov 30, 2023 at 10:40:46AM +0800, Tengfei Fan wrote:
The address offset of 0x100000 is already provided in SM4450 DTSI, so
subtract 0x100000 from the offset which used by ufs and sdc.


As Konrad points out, please fix the broken patch, don't add a separate
fix in the same series.

Suggested-by: Can Guo <quic_cang@xxxxxxxxxxx>

We unfortunately don't have a way to give credit to those providing
review feedback, so omit this when fixing patch #2.

Just write in the commit message that Can Guo helped out in reviewing
the driver (just some free text).

Yours,
Linus Walleij
Thanks for your suggestions, The next version patch commit message will contain some description information.

--
Thx and BRs,
Tengfei Fan