Re: [PATCH 5.4 00/94] 5.4.263-rc1 review

[Greg Kroah-Hartman]

On Mon, Dec 04, 2023 at 07:53:26PM -0800, Guenter Roeck wrote:
> On 12/4/23 19:16, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.263 release.
> > There are 94 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu, 07 Dec 2023 03:14:57 +0000.
> > Anything received after that time might be too late.
> > 
> 
> Building arm64:allmodconfig ... failed
> --------------
> Error log:
> drivers/mmc/host/sdhci-sprd.c: In function 'sdhci_sprd_set_power':
> drivers/mmc/host/sdhci-sprd.c:393:17: error: implicit declaration of function 'mmc_regulator_disable_vqmmc'; did you mean 'mmc_regulator_set_vqmmc'? [-Werror=implicit-function-declaration]
>   393 |                 mmc_regulator_disable_vqmmc(mmc);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                 mmc_regulator_set_vqmmc
> drivers/mmc/host/sdhci-sprd.c:396:17: error: implicit declaration of function 'mmc_regulator_enable_vqmmc'; did you mean 'mmc_regulator_set_vqmmc'? [-Werror=implicit-function-declaration]
>   396 |                 mmc_regulator_enable_vqmmc(mmc);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                 mmc_regulator_set_vqmmc
> 
> Commit 2b11e5bd4ac0 ("mmc: sdhci-sprd: Fix vqmmc not shutting down after
> the card was pulled") calls those functions without introducing them.

Ick, missed that somehow, I thought I had caught it already.  I'll go
drop it now and push out a -rc2.

thanks,

greg k-h