Re: [PATCH 4.19 00/71] 4.19.301-rc1 review

[Harshit Mogalapalli]

Hi Greg,

On 05/12/23 8:45 am, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.301 release.
> There are 71 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 03:14:57 +0000.
> Anything received after that time might be too late.

I see build failure in tools/perf/

util/intel-pt.c: In function ‘intel_pt_sample_flags’:
util/intel-pt.c:906:38: error: ‘const struct intel_pt_state’ has no 
member named ‘from_nr’; did you mean ‘from_ip’?
  906 |                 else if (ptq->state->from_nr && !ptq->state->to_nr)
      |                                      ^~~~~~~
      |                                      from_ip
util/intel-pt.c:906:60: error: ‘const struct intel_pt_state’ has no 
member named ‘to_nr’
  906 |                 else if (ptq->state->from_nr && !ptq->state->to_nr)
      |                                                            ^~
util/intel-pt.c:909:38: error: ‘PERF_IP_FLAG_VMEXIT’ undeclared (first 
use in this function); did you mean ‘PERF_IP_FLAG_IN_TX’?
  909 |                                      PERF_IP_FLAG_VMEXIT;
      |                                      ^~~~~~~~~~~~~~~~~~~
      |                                      PERF_IP_FLAG_IN_TX

> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.301-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -----------
>
> Adrian Hunter <adrian.hunter@xxxxxxxxx>
>      perf intel-pt: Fix async branch flags
>
> Adrian Hunter <adrian.hunter@xxxxxxxxx>
>      perf intel-pt: Adjust sample flags for VM-Exit
This is caused due to these two commits. Let us drop them.

I reverted those two and did a make, then I see another build error:

  CC       util/genelf.o
In file included from util/jitdump.c:27:
util/genelf.h:5:10: fatal error: linux/math.h: No such file or directory
    5 | #include <linux/math.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [~/linux-stable-rc/tools/build/Makefile.build:97: 
util/jitdump.o] Error 1
make[4]: *** Waiting for unfinished jobs....
In file included from util/genelf.c:27:
util/genelf.h:5:10: fatal error: linux/math.h: No such file or directory
    5 | #include <linux/math.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.


> Adrian Hunter <adrian.hunter@xxxxxxxxx>
>     perf inject: Fix GEN_ELF_TEXT_OFFSET for jit

^^^ this commit is causing this.

Earlier we have seen similar errors on 5.15.136, some notes on what is 
causing this:
https://lore.kernel.org/stable/fb1ce733-d612-4fa3-a1e4-716545625822@xxxxxxxxxx/

I think we should drop these three perf/ commits.

Thanks,
Harshit